root/xz
1
0
Fork 0
mirror of https://git.tukaani.org/xz.git synced 2025-10-31 21:43:04 +00:00
Code Issues Releases Wiki Activity

CI: Valgrind: Improve the skipping of traced child processes

Browse Source 
Use --trace-children-skip instead of --trace-children-skip-by-arg
so that the skipping is only done based on the executable names.
(--trace-children-skip-by-arg can match other args than argv[0].)

Update the list of executables to skip to match what the scripts run.

Do not skip bash or sh. If Valgrind didn't trace the shell, then the
xz and xzdec programs run by the shell wouldn't be analyzed either.

Fixes: 7e99856f66c0 ("CI: Speed up Valgrind job by using --trace-children-skip-by-arg=...")
This commit is contained in:
Lasse Collin 2025-04-22 21:12:50 +03:00
parent f33da20b75
commit 56aa9a0796
No known key found for this signature in database
GPG Key ID: 38EE757D69184620
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.github/workflows/ci.yml vendored
View File

@ -103,7 +103,7 @@ jobs:
- name: Test with Valgrind - name: Test with Valgrind
if: ${{ startsWith(matrix.os, 'ubuntu') && matrix.build_system == 'autotools' }} if: ${{ startsWith(matrix.os, 'ubuntu') && matrix.build_system == 'autotools' }}
run: | run: |
./build-aux/ci_build.bash -b autotools -p test -d sandbox -w "valgrind --quiet --trace-children=yes --trace-children-skip-by-arg=ls,cp,sed,grep,bash,sh --exit-on-first-error=yes --error-exitcode=1" ./build-aux/ci_build.bash -b autotools -p test -d sandbox -w "valgrind --quiet --trace-children=yes --trace-children-skip=*/cmp,*/cp,*/diff,*/grep,*/rm,*/sed --exit-on-first-error=yes --error-exitcode=1"
cd ../xz_build && make distclean cd ../xz_build && make distclean
- name: Build with musl libc - name: Build with musl libc