From 56aa9a07968a6a73fada6f9b96122c5165829f3b Mon Sep 17 00:00:00 2001 From: Lasse Collin Date: Tue, 22 Apr 2025 21:12:50 +0300 Subject: [PATCH] CI: Valgrind: Improve the skipping of traced child processes Use --trace-children-skip instead of --trace-children-skip-by-arg so that the skipping is only done based on the executable names. (--trace-children-skip-by-arg can match other args than argv[0].) Update the list of executables to skip to match what the scripts run. Do not skip bash or sh. If Valgrind didn't trace the shell, then the xz and xzdec programs run by the shell wouldn't be analyzed either. Fixes: 7e99856f66c0 ("CI: Speed up Valgrind job by using --trace-children-skip-by-arg=...") --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 80941b6b..43cbcbc1 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -103,7 +103,7 @@ jobs: - name: Test with Valgrind if: ${{ startsWith(matrix.os, 'ubuntu') && matrix.build_system == 'autotools' }} run: | - ./build-aux/ci_build.bash -b autotools -p test -d sandbox -w "valgrind --quiet --trace-children=yes --trace-children-skip-by-arg=ls,cp,sed,grep,bash,sh --exit-on-first-error=yes --error-exitcode=1" + ./build-aux/ci_build.bash -b autotools -p test -d sandbox -w "valgrind --quiet --trace-children=yes --trace-children-skip=*/cmp,*/cp,*/diff,*/grep,*/rm,*/sed --exit-on-first-error=yes --error-exitcode=1" cd ../xz_build && make distclean - name: Build with musl libc