root
/
meta
3
1
Fork 0
Code Issues 3 Pull Requests Releases Wiki Activity

Update page 'Move to Approve'

AJ ONeal 2019-05-18 18:14:41 +00:00
parent cb7f2bd881
commit da963d27fb
1 changed files with 22 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
Move-to-Approve.md

@ -20,18 +20,33 @@ We acknowledge that the reason someone creates a PR is likely:
Therefore our responsibility is to: Therefore our responsibility is to:
1. Determine if there's any reason the PR **shouldn't** go through 1. Determine if there's any reason the PR **shouldn't** go through:
* (i.e. it's out of line with the project goals) * It's out of line with the project goals
* The project isn't actively maintained
2. Help the contributor get 80% of the way there 2. Help the contributor get 80% of the way there
* Determine criteria that need to be met to move forward * Determine criteria that need to be met to move forward
3. Make the last few changes, if needed (rename a thing, fix a space)
## 2. Pair to Prepare
We'll have a channel open on Keybase and set aside some "office hours" for pairing
to work through PRs.
## 3. Opinions are the Burden of the Bearer
## 2. Opinions are the Burden of the Bearer We need to clearly express broad over-archiving philosophy and values, and not sweat the small stuff.
## 3. Remain Politically Neutral Where possible we should be using tools that solve style issues so that they're not a concern.
Where that's not possible we shouldn't let style issues get in the way of bugfixes, new features, or
anything that has _real_ value to those that use the software.
If the maintainer has a strong opinion about a variable name, style of loop, etc, it becomes their
responsibility to demonstrate that they care that much about it by making a follow-up PR
(or requesting a follow-up PR), rather than to burden the contributor with non-essential opinions.
Iteration is better than perfection.
## 4. Remain Politically Neutral
First off, we recognize that everyone has moral (and amoral) values that they feel strongly about and want to enforce among other people. This is a natural human tendency. That doesn't make mud-slinging okay, but it does make it **forgivable**. First off, we recognize that everyone has moral (and amoral) values that they feel strongly about and want to enforce among other people. This is a natural human tendency. That doesn't make mud-slinging okay, but it does make it **forgivable**.
@ -54,7 +69,7 @@ with our values of tolerance than blocking.
We value **individuality** (it comes with the name). We value **individuality** (it comes with the name).
This is a **safe** space to have an opinion and to express it, even if it possibly offends someone, This is a **safe** space to have an opinion and to express it, even if it possibly offends someone,
as long as you're also open to feedback and you **don't become obnoxious**. as long as you're also open to feedback and you **don't become obnoxious** (and don't swear like a sailor - this is Root, not San Francisco).
That said, please don't preach political views or mud-sling. Incidental conversation is fine. We'll block obnoxious people. That said, please don't preach political views or mud-sling. Incidental conversation is fine. We'll block obnoxious people.