root
/
keypairs
mirror of https://github.com/therootcompany/keypairs
2
0
Fork 0
Code Issues Releases Wiki Activity

Warn on empty string in whitelist

This commit is contained in:
AJ ONeal 2019-04-17 17:08:53 -06:00
parent 671ea1250d
commit 6fc75632c8
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
keyfetch/fetch.go
View File

@ -409,6 +409,10 @@ func NewWhitelist(issuers []string, privateList ...[]string) (Whitelist, error)
func newWhitelist(list []*url.URL, issuers []string, insecure bool) (Whitelist, error) { func newWhitelist(list []*url.URL, issuers []string, insecure bool) (Whitelist, error) {
for i := range issuers { for i := range issuers {
iss := issuers[i] iss := issuers[i]
if "" == strings.TrimSpace(iss) {
fmt.Println("[Warning] You have an empty string in your keyfetch whitelist.")
continue
}
// Should have a valid http or https prefix // Should have a valid http or https prefix
// TODO support custom prefixes (i.e. app://) ? // TODO support custom prefixes (i.e. app://) ?

4
keyfetch/issuer_test.go
View File

@ -20,7 +20,9 @@ func TestInvalidIssuer(t *testing.T) {
} }
func TestIssuerMatches(t *testing.T) { func TestIssuerMatches(t *testing.T) {
// because [""] = strings.Split(os.Getenv("DOESNTEXIST"), ",")
trusted := []string{ trusted := []string{
"",
"https://example.com/", "https://example.com/",
"foobar.net/def/", "foobar.net/def/",
"https://*.wild.org", "https://*.wild.org",
@ -41,7 +43,7 @@ func TestIssuerMatches(t *testing.T) {
t.Fatal(err) t.Fatal(err)
} }
// Combo list // Combo list
list, err = NewWhitelist(trusted, privates) list, err = NewWhitelist(trusted[1:], privates)
if nil != err { if nil != err {
t.Fatal(err) t.Fatal(err)
} }