v1.1.2: consistently use bucketRegion, not regionName

This commit is contained in:
AJ ONeal 2019-05-25 22:24:19 -06:00
parent 66602b9a10
commit ca5127cd06
4 changed files with 10 additions and 10 deletions

View File

@ -23,7 +23,7 @@ You will need a s3 bucket and the corresponding credentials.
let store = require('greenlock-storage-s3').create({ let store = require('greenlock-storage-s3').create({
accessKeyId: accessKeyId // Replace with your accessKeyId accessKeyId: accessKeyId // Replace with your accessKeyId
, secretAccessKey: secretAccessKey // Replace with your secretAccessKey , secretAccessKey: secretAccessKey // Replace with your secretAccessKey
, bucketRegion: regionName // Replace with your regionName , bucketRegion: bucketRegion // Replace with your bucketRegion
, bucketName: bucketName // Replace with your bucketName , bucketName: bucketName // Replace with your bucketName
, configDir: 'acme/' // Recommended , configDir: 'acme/' // Recommended
, accountsDir: 'accounts/' // Recommended , accountsDir: 'accounts/' // Recommended
@ -51,11 +51,11 @@ To run the tests yourself, create a `.env` file with the following
// .env file // .env file
AWS_ACCESS_KEY_ID=abc // Replace with your accessKeyId AWS_ACCESS_KEY_ID=abc // Replace with your accessKeyId
AWS_SECRET_ACCESS_KEY=abc // Replace with your secretAccessKey AWS_SECRET_ACCESS_KEY=abc // Replace with your secretAccessKey
AWS_BUCKET_REGION=abc // Replace with your regionName AWS_BUCKET_REGION=abc // Replace with your bucketRegion
AWS_BUCKET_NAME=abc // Replace with your bucketName AWS_BUCKET_NAME=abc // Replace with your bucketName
``` ```
Run the following command: Run the following command:
```console ```console
$ npm run clean && npm run test && npm run clean $ npm run clean && npm run test && npm run clean
``` ```

View File

@ -4,13 +4,13 @@ require("dotenv").config();
let accessKeyId = process.env.AWS_ACCESS_KEY_ID let accessKeyId = process.env.AWS_ACCESS_KEY_ID
, secretAccessKey = process.env.AWS_SECRET_ACCESS_KEY , secretAccessKey = process.env.AWS_SECRET_ACCESS_KEY
, regionName = process.env.AWS_BUCKET_REGION , bucketRegion = process.env.AWS_BUCKET_REGION
, bucketName = process.env.AWS_BUCKET_NAME; , bucketName = process.env.AWS_BUCKET_NAME;
var AWS = require("aws-sdk"); var AWS = require("aws-sdk");
AWS.config.setPromisesDependency(Promise); AWS.config.setPromisesDependency(Promise);
AWS.config.update({ AWS.config.update({
region: regionName region: bucketRegion
, credentials: new AWS.Credentials({ , credentials: new AWS.Credentials({
accessKeyId accessKeyId
, secretAccessKey , secretAccessKey
@ -43,4 +43,4 @@ s3.listObjects({ Bucket: bucketName }).promise().then((data) => {
}).catch((err) => { }).catch((err) => {
console.error(err.message); console.error(err.message);
throw err; throw err;
}); });

View File

@ -1,6 +1,6 @@
{ {
"name": "greenlock-storage-s3", "name": "greenlock-storage-s3",
"version": "1.1.0", "version": "1.1.2",
"description": "S3 backed storage strategy for greenlock-express.js (and greenlock.js)", "description": "S3 backed storage strategy for greenlock-express.js (and greenlock.js)",
"main": "index.js", "main": "index.js",
"scripts": { "scripts": {

View File

@ -4,7 +4,7 @@ require("dotenv").config();
let accessKeyId = process.env.AWS_ACCESS_KEY_ID let accessKeyId = process.env.AWS_ACCESS_KEY_ID
, secretAccessKey = process.env.AWS_SECRET_ACCESS_KEY , secretAccessKey = process.env.AWS_SECRET_ACCESS_KEY
, regionName = process.env.AWS_BUCKET_REGION , bucketRegion = process.env.AWS_BUCKET_REGION
, bucketName = process.env.AWS_BUCKET_NAME; , bucketName = process.env.AWS_BUCKET_NAME;
let tester = require("greenlock-store-test"); let tester = require("greenlock-store-test");
@ -12,7 +12,7 @@ let tester = require("greenlock-store-test");
let store = require("./index").create({ let store = require("./index").create({
accessKeyId accessKeyId
, secretAccessKey , secretAccessKey
, regionName , bucketRegion
, bucketName , bucketName
, configDir: "acme/" , configDir: "acme/"
, accountsDir: "accounts/" , accountsDir: "accounts/"
@ -25,4 +25,4 @@ tester.test(store).then(() => {
}).catch((err) => { }).catch((err) => {
console.error(err.message); console.error(err.message);
throw err; throw err;
}); });