root
/
gitdeploy
2
0
Fork 0
Code Issues 3 Pull Requests Releases Wiki Activity

bugfix: remove extraneous return

This commit is contained in:
AJ ONeal 2021-03-17 17:51:35 -06:00
parent 0fcea9342f
commit c2085858a7
2 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
internal/jobs/job.go
View File

@ -461,7 +461,6 @@ func run(curHook *webhooks.Ref, runOpts *options.ServerConfig) {
Actives.Store(pendingID, j) Actives.Store(pendingID, j)
go func() { go func() {
// TODO make configurable
timer := time.AfterFunc(runOpts.DefaultMaxJobTime, func() { timer := time.AfterFunc(runOpts.DefaultMaxJobTime, func() {
if nil == cmd.Process { if nil == cmd.Process {
log.Printf("[SANITY] [%s] never exited, but does not exist", pendingID) log.Printf("[SANITY] [%s] never exited, but does not exist", pendingID)

3
internal/jobs/job_test.go
View File

@ -240,13 +240,12 @@ func TestRecents(t *testing.T) {
urlRevID := webhooks.URLSafeGitID( urlRevID := webhooks.URLSafeGitID(
base64.RawURLEncoding.EncodeToString([]byte(hook.GetRevID())), base64.RawURLEncoding.EncodeToString([]byte(hook.GetRevID())),
) )
//lint:ignore SA4006 The linter is wrong, j is used
j, err = LoadLogs(runOpts, urlRevID) j, err = LoadLogs(runOpts, urlRevID)
if nil != err { if nil != err {
t.Errorf("error loading logs: %v", err) t.Errorf("error loading logs: %v", err)
return return
} }
return
} }
if len(j.Logs) < 3 { if len(j.Logs) < 3 {