diff --git a/internal/jobs/job.go b/internal/jobs/job.go index bed0423..736c5b7 100644 --- a/internal/jobs/job.go +++ b/internal/jobs/job.go @@ -461,7 +461,6 @@ func run(curHook *webhooks.Ref, runOpts *options.ServerConfig) { Actives.Store(pendingID, j) go func() { - // TODO make configurable timer := time.AfterFunc(runOpts.DefaultMaxJobTime, func() { if nil == cmd.Process { log.Printf("[SANITY] [%s] never exited, but does not exist", pendingID) diff --git a/internal/jobs/job_test.go b/internal/jobs/job_test.go index f8a1faa..1dc801b 100644 --- a/internal/jobs/job_test.go +++ b/internal/jobs/job_test.go @@ -240,13 +240,12 @@ func TestRecents(t *testing.T) { urlRevID := webhooks.URLSafeGitID( base64.RawURLEncoding.EncodeToString([]byte(hook.GetRevID())), ) - //lint:ignore SA4006 The linter is wrong, j is used + j, err = LoadLogs(runOpts, urlRevID) if nil != err { t.Errorf("error loading logs: %v", err) return } - return } if len(j.Logs) < 3 {