1
0
mirror of https://git.tukaani.org/xz.git synced 2025-02-17 14:08:12 +00:00
xz/tests/test_files.sh
Lasse Collin 1107712e37 Remove the backdoor found in 5.6.0 and 5.6.1 (CVE-2024-3094).
While the backdoor was inactive (and thus harmless) without inserting
a small trigger code into the build system when the source package was
created, it's good to remove this anyway:

  - The executable payloads were embedded as binary blobs in
    the test files. This was a blatant violation of the
    Debian Free Software Guidelines.

  - On machines that see lots bots poking at the SSH port, the backdoor
    noticeably increased CPU load, resulting in degraded user experience
    and thus overwhelmingly negative user feedback.

  - The maintainer who added the backdoor has disappeared.

  - Backdoors are bad for security.

This reverts the following without making any other changes:

6e636819 Tests: Update two test files.
a3a29bbd Tests: Test --single-stream can decompress bad-3-corrupt_lzma2.xz.
0b4ccc91 Tests: Update RISC-V test files.
8c9b8b20 liblzma: Fix typos in crc32_fast.c and crc64_fast.c.
82ecc538 liblzma: Fix false Valgrind error report with GCC.
cf44e4b7 Tests: Add a few test files.
3060e107 Tests: Use smaller dictionary size in RISC-V test files.
e2870db5 Tests: Add two RISC-V Filter test files.

The RISC-V test files also have real content that tests the filter
but the real content would fit into much smaller files. A generator
program would need to be available as well.

Thanks to Andres Freund for finding and reporting it and making
it public quickly so others could act without a delay.
See: https://www.openwall.com/lists/oss-security/2024/03/29/4
2024-04-09 18:38:37 +03:00

201 lines
4.3 KiB
Bash
Executable File

#!/bin/sh
# SPDX-License-Identifier: 0BSD
###############################################################################
#
# Author: Lasse Collin
#
###############################################################################
# If both xz and xzdec were not built, skip this test.
XZ=../src/xz/xz
XZDEC=../src/xzdec/xzdec
test -x "$XZ" || XZ=
test -x "$XZDEC" || XZDEC=
if test -z "$XZ$XZDEC"; then
echo "xz and xzdec were not built, skipping this test."
exit 77
fi
# If decompression support is missing, this test is skipped.
# This isn't perfect as if only some decompressors are disabled
# then some good files might not decompress and the test fails
# for a (kind of) wrong reason.
if grep 'define HAVE_DECODERS' ../config.h > /dev/null ; then
:
else
echo "Decompression support is disabled, skipping this test."
exit 77
fi
# If a feature was disabled at build time, make it possible to skip
# some of the test files. Use exit status 77 if any files were skipped.
EXIT_STATUS=0
have_feature()
{
grep "define HAVE_$1 1" ../config.h > /dev/null && return 0
printf '%s: Skipping because HAVE_%s is not enabled\n' "$2" "$1"
EXIT_STATUS=77
return 1
}
#######
# .xz #
#######
# If these integrity check types were disabled at build time,
# allow the tests to pass still.
NO_WARN=
grep 'define HAVE_CHECK_CRC64' ../config.h > /dev/null || NO_WARN=-qQ
grep 'define HAVE_CHECK_SHA256' ../config.h > /dev/null || NO_WARN=-qQ
for I in "$srcdir"/files/good-*.xz
do
# If features were disabled at build time, keep this still working.
case $I in
*/good-1-*delta-lzma2*.xz)
have_feature DECODER_DELTA "$I" || continue
;;
esac
case $I in
*/good-1-empty-bcj-lzma2.xz)
have_feature DECODER_POWERPC "$I" || continue
;;
esac
case $I in
*/good-1-sparc-lzma2.xz)
have_feature DECODER_SPARC "$I" || continue
;;
esac
case $I in
*/good-1-x86-lzma2.xz)
have_feature DECODER_X86 "$I" || continue
;;
esac
case $I in
*/good-1-arm64-lzma2-*.xz)
have_feature DECODER_ARM64 "$I" || continue
;;
esac
case $I in
*/good-1-riscv-lzma2-*.xz)
have_feature DECODER_RISCV "$I" || continue
;;
esac
if test -z "$XZ" || "$XZ" $NO_WARN -dc "$I" > /dev/null; then
:
else
echo "Good file failed: $I"
exit 1
fi
if test -z "$XZDEC" || "$XZDEC" $NO_WARN "$I" > /dev/null; then
:
else
echo "Good file failed: $I"
exit 1
fi
done
for I in "$srcdir"/files/bad-*.xz
do
if test -n "$XZ" && "$XZ" -dc "$I" > /dev/null 2>&1; then
echo "Bad file succeeded: $I"
exit 1
fi
# xzdec doesn't warn about unsupported check so skip this if any of
# the check types were disabled at built time (NO_WARN isn't empty).
if test -n "$XZDEC" && test -z "$NO_WARN" \
&& "$XZDEC" "$I" > /dev/null 2>&1; then
echo "Bad file succeeded: $I"
exit 1
fi
done
# Testing for the lzma_index_append() bug in <= 5.2.6 needs "xz -l":
I="$srcdir/files/bad-3-index-uncomp-overflow.xz"
if test -n "$XZ" && "$XZ" -l "$I" > /dev/null 2>&1; then
echo "Bad file succeeded with xz -l: $I"
exit 1
fi
for I in "$srcdir"/files/unsupported-*.xz
do
# Test these only with xz as unsupported-check.xz will exit
# successfully with xzdec because it doesn't warn about
# unsupported check type.
if test -n "$XZ" && "$XZ" -dc "$I" > /dev/null 2>&1; then
echo "Unsupported file succeeded: $I"
exit 1
fi
done
# Test that this passes with --no-warn (-Q).
I="$srcdir/files/unsupported-check.xz"
if test -z "$XZ" || "$XZ" -dcqQ "$I" > /dev/null; then
:
else
echo "Unsupported file failed with xz -Q: $I"
exit 1
fi
if test -z "$XZDEC" || "$XZDEC" -qQ "$I" > /dev/null; then
:
else
echo "Unsupported file failed with xzdec -Q: $I"
exit 1
fi
#########
# .lzma #
#########
for I in "$srcdir"/files/good-*.lzma
do
if test -z "$XZ" || "$XZ" -dc "$I" > /dev/null; then
:
else
echo "Good file failed: $I"
exit 1
fi
done
for I in "$srcdir"/files/bad-*.lzma
do
if test -n "$XZ" && "$XZ" -dc "$I" > /dev/null 2>&1; then
echo "Bad file succeeded: $I"
exit 1
fi
done
#######
# .lz #
#######
if have_feature LZIP_DECODER ".lz files" ; then
for I in "$srcdir"/files/good-*.lz
do
if test -z "$XZ" || "$XZ" -dc "$I" > /dev/null; then
:
else
echo "Good file failed: $I"
exit 1
fi
done
for I in "$srcdir"/files/bad-*.lz "$srcdir"/files/unsupported-*.lz
do
if test -n "$XZ" && "$XZ" -dc "$I" > /dev/null 2>&1; then
echo "Bad file succeeded: $I"
exit 1
fi
done
fi
exit "$EXIT_STATUS"