root
/
xz
mirror of https://git.tukaani.org/xz.git
1
0
Fork 0
Code Issues Releases Wiki Activity

Tests: test_microlzma: Add a "FIXME?" about LZMA_FINISH handling

This commit is contained in:
Lasse Collin 2024-04-13 22:19:40 +03:00
parent 0fe2dfa683
commit fcbd0d1999
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
tests/test_microlzma.c
View File

@ -411,7 +411,15 @@ test_decode_uncomp_size_wrong(void)
// No error detected, even though all input was consumed and there // No error detected, even though all input was consumed and there
// is more room in the output buffer. // is more room in the output buffer.
//
// FIXME? LZMA_FINISH tells that no more input is coming and
// the MicroLZMA decoder knows the exact compressed size from
// the initialization as well. So should it return LZMA_DATA_ERROR
// on the first call instead of relying on the generic lzma_code()
// logic to eventually get LZMA_BUF_ERROR?
assert_lzma_ret(lzma_code(&strm, LZMA_FINISH), LZMA_OK); assert_lzma_ret(lzma_code(&strm, LZMA_FINISH), LZMA_OK);
assert_lzma_ret(lzma_code(&strm, LZMA_FINISH), LZMA_OK);
assert_lzma_ret(lzma_code(&strm, LZMA_FINISH), LZMA_BUF_ERROR);
assert_uint_eq(strm.total_out, sizeof(goodbye_world)); assert_uint_eq(strm.total_out, sizeof(goodbye_world));
assert_array_eq(goodbye_world, output, sizeof(goodbye_world)); assert_array_eq(goodbye_world, output, sizeof(goodbye_world));