diff --git a/src/liblzma/check/crc32_fast.c b/src/liblzma/check/crc32_fast.c index bfa295a0..079051f1 100644 --- a/src/liblzma/check/crc32_fast.c +++ b/src/liblzma/check/crc32_fast.c @@ -135,8 +135,11 @@ typedef uint32_t (*crc32_func_type)( // This resolver is shared between all three dispatch methods. It serves as // the ifunc resolver if ifunc is supported, otherwise it is called as a // regular function by the constructor or first call resolution methods. -// The function attributes are needed for safe IFUNC resolver usage with GCC. -lzma_resolver_attributes +// The __no_profile_instrument_function__ attribute support is checked when +// determining if ifunc can be used, so it is safe to use here. +#ifdef CRC_USE_IFUNC +__attribute__((__no_profile_instrument_function__)) +#endif static crc32_func_type crc32_resolve(void) { diff --git a/src/liblzma/check/crc64_fast.c b/src/liblzma/check/crc64_fast.c index 52cddb2c..5728b45e 100644 --- a/src/liblzma/check/crc64_fast.c +++ b/src/liblzma/check/crc64_fast.c @@ -98,7 +98,9 @@ typedef uint64_t (*crc64_func_type)( # pragma GCC diagnostic ignored "-Wunused-function" #endif -lzma_resolver_attributes +#ifdef CRC_USE_IFUNC +__attribute__((__no_profile_instrument_function__)) +#endif static crc64_func_type crc64_resolve(void) { diff --git a/src/liblzma/check/crc_common.h b/src/liblzma/check/crc_common.h index 5a86556f..856665db 100644 --- a/src/liblzma/check/crc_common.h +++ b/src/liblzma/check/crc_common.h @@ -128,31 +128,6 @@ # endif #endif -#ifdef CRC_USE_IFUNC -// Two function attributes are needed to make IFUNC safe with GCC. -// -// no-omit-frame-pointer prevents false Valgrind issues when combined with -// a few other compiler flags. The optimize attribute is supported on -// GCC >= 4.4 and is not supported with Clang. -# if TUKLIB_GNUC_REQ(4,4) && !defined(__clang__) -# define no_omit_frame_pointer \ - __attribute__((optimize("no-omit-frame-pointer"))) -# else -# define no_omit_frame_pointer -# endif - -// The __no_profile_instrument_function__ attribute support is checked when -// determining if ifunc can be used, so it is safe to use unconditionally. -// This attribute is needed because GCC can add profiling to the IFUNC -// resolver, which calls functions that have not yet been relocated leading -// to a crash on liblzma start up. -# define lzma_resolver_attributes \ - __attribute__((__no_profile_instrument_function__)) \ - no_omit_frame_pointer -#else -# define lzma_resolver_attributes -#endif - // For CRC32 use the generic slice-by-eight implementation if no optimized // version is available. #if !defined(CRC32_ARCH_OPTIMIZED) && !defined(CRC32_GENERIC) diff --git a/tests/files/README b/tests/files/README index e987a519..a3208459 100644 --- a/tests/files/README +++ b/tests/files/README @@ -41,8 +41,6 @@ good-0catpad-empty.xz has two zero-Block Streams concatenated with four-byte Stream Padding between the Streams. - good-2cat.xz has two Streams with one Block each. - good-1-check-none.xz has one Stream with one Block with two uncompressed LZMA2 chunks and no integrity check. @@ -83,14 +81,6 @@ good-1-arm64-lzma2-2.xz is like good-1-arm64-lzma2-1.xz but with non-zero start offset. XZ Embedded doesn't support this file. - good-1-riscv-lzma2-1.xz uses the RISC-V filter and LZMA2. The - uncompressed data is constructed so it tests all of the instructions - that should be encoded and a few that should not. Additionally, the - file contains random bytes to help test unforeseen corner cases. - - good-1-riscv-lzma2-2.xz is like good-1-riscv-lzma2-1.xz but with - non-zero start offset. XZ Embedded doesn't support this file. - good-1-lzma2-1.xz has two LZMA2 chunks, of which the second sets new properties. @@ -294,11 +284,6 @@ Uncompressed Size bytes of output will have been produced but the LZMA2 decoder doesn't indicate end of stream. - bad-3-corrupt_lzma2.xz has three Streams in it. The first and third - streams are valid xz Streams. The middle Stream has a correct Stream - Header, Block Header, Index and Stream Footer. Only the LZMA2 data - is corrupt. This file should decompress if --single-stream is used. - 3. Descriptions of Individual .lzma Files @@ -315,14 +300,6 @@ will give an error at the end of the file after producing the correct uncompressed output. - good-small_compressed.lzma was created with a small dictionary (2^16). - It contains the string "Hello World" repeated 100,000 times. This tests - match decoding and wrapping the dictionary. - - good-large_compressed.lzma was created with a mix of repeated - characters and random data to test a data stream containing many - matches and many literals. - 3.2. Bad Files @@ -344,10 +321,6 @@ bad-too_small_size-without_eopm-3.lzma is like -1 above but instead of a literal the problem occurs in the middle of a match. - bad-dict_size.lzma has a valid dictionary size according to the .lzma - File Format, but will be rejected by XZ Utils because it is not 2^n or - 2^n + 2^(n-1). - 4. Descriptions of Individual .lz (lzip) Files diff --git a/tests/files/bad-3-corrupt_lzma2.xz b/tests/files/bad-3-corrupt_lzma2.xz deleted file mode 100644 index f9ec69a2..00000000 Binary files a/tests/files/bad-3-corrupt_lzma2.xz and /dev/null differ diff --git a/tests/files/bad-dict_size.lzma b/tests/files/bad-dict_size.lzma deleted file mode 100644 index f2ef5a58..00000000 Binary files a/tests/files/bad-dict_size.lzma and /dev/null differ diff --git a/tests/files/good-1-riscv-lzma2-1.xz b/tests/files/good-1-riscv-lzma2-1.xz deleted file mode 100644 index 85f3b756..00000000 Binary files a/tests/files/good-1-riscv-lzma2-1.xz and /dev/null differ diff --git a/tests/files/good-1-riscv-lzma2-2.xz b/tests/files/good-1-riscv-lzma2-2.xz deleted file mode 100644 index 60d2403a..00000000 Binary files a/tests/files/good-1-riscv-lzma2-2.xz and /dev/null differ diff --git a/tests/files/good-2cat.xz b/tests/files/good-2cat.xz deleted file mode 100644 index ea4d6270..00000000 Binary files a/tests/files/good-2cat.xz and /dev/null differ diff --git a/tests/files/good-large_compressed.lzma b/tests/files/good-large_compressed.lzma deleted file mode 100644 index 878991f3..00000000 Binary files a/tests/files/good-large_compressed.lzma and /dev/null differ diff --git a/tests/files/good-small_compressed.lzma b/tests/files/good-small_compressed.lzma deleted file mode 100644 index a2fe8022..00000000 Binary files a/tests/files/good-small_compressed.lzma and /dev/null differ diff --git a/tests/test_files.sh b/tests/test_files.sh index 812b2152..16cb8619 100755 --- a/tests/test_files.sh +++ b/tests/test_files.sh @@ -149,17 +149,6 @@ else exit 1 fi -# Test that --single-stream can decompress bad-3-corrupt_lzma2.xz. -# The first Stream in this file should decompress without errors. -# This file cannot be decompressed with xzdec. -I="$srcdir/files/bad-3-corrupt_lzma2.xz" -if test -z "$XZ" || "$XZ" -dc --single-stream $NO_WARN "$I" > /dev/null; then - : -else - echo "Good first Stream failed xz with --single-stream: $I" - exit 1 -fi - ######### # .lzma #