root/xz
1
0
Fork 0
mirror of https://git.tukaani.org/xz.git synced 2025-10-28 03:52:52 +00:00
Code Issues Releases Wiki Activity

xz: Avoid arithmetic on a null pointer

Browse Source 
It's undefined behavior. The result wasn't ever used as it occurred
in the last iteration of a loop.

Clang 17 with -fsanitize=address,undefined:

    $ src/xz/xz --block-list=123
    src/xz/args.c:164:12: runtime error: applying non-zero offset 1
        to null pointer

Fixes: 88ccf47205d7f3aa314d358c72ef214f10f68b43
Co-authored-by: Sam James <sam@gentoo.org>
(cherry picked from commit 77c8f60547decefca8f2d0c905d9c708c38ee8ff)
(cherry picked from commit 203d48259935bad1c26e35d42f3db3c0f414bd8c)
This commit is contained in:
Lasse Collin 2024-04-30 21:41:11 +03:00
parent ecbc34d90b
commit b933ef49a5
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/xz/args.c
View File

@ -120,7 +120,13 @@ parse_block_list(const char *str_const)
}
}
str = p + 1;
// Be standards compliant: p + 1 is undefined behavior
// if p == NULL. That occurs on the last iteration of
// the loop when we won't care about the value of str
// anymore anyway. That is, this is done conditionally
// solely for standard conformance reasons.
if (p != NULL)
str = p + 1;
}
// Terminate the array.