root/xz
1
0
Fork 0
mirror of https://git.tukaani.org/xz.git synced 2025-05-23 22:56:44 +00:00
Code Issues Releases Wiki Activity

xz: Capsicum sandbox: Fix incorrect use of cap_rights_clear()

Browse Source 
cap_rights_clear() with no additional arguments acts as a no-op, so
instead of removing all capability rights from STDIN_FILENO, the same
rights were allowed for STDIN_FILENO as were allowed for src_fd.

Co-authored-by: Guillaume Outters <guillaume-installs@outters.eu>
Fixes: fd56d5353360 ("xz: Make Capsicum sandbox more strict with stdin and stdout.")
(The commit message says "stdout". It should have said "stderr".)

(based on commit 5cc2e479eb447a444f5ab005fc36b7f275c75eb5)
This commit is contained in:
Lasse Collin 2025-04-28 18:22:32 +03:00
parent 20ec36eafd
commit b593c1f95b
No known key found for this signature in database
GPG Key ID: 38EE757D69184620
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/xz/file_io.c
View File

@ -201,7 +201,7 @@ io_sandbox_enter(int src_fd)
// If not reading from stdin, remove all capabilities from it.
if (src_fd != STDIN_FILENO && cap_rights_limit(
STDIN_FILENO, cap_rights_clear(&rights)))
STDIN_FILENO, cap_rights_init(&rights)))
goto error;
if (cap_rights_limit(STDOUT_FILENO, cap_rights_init(&rights,