From 6cc2da0a4b180b71cb6e781c897052def103ad3e Mon Sep 17 00:00:00 2001 From: Lasse Collin Date: Sun, 2 Nov 2025 12:57:00 +0200 Subject: [PATCH] liblzma: Refactor a loop in lzma_filters_copy() Arguably it's nicer if i doesn't wrap around when the loop terminates. Fixes: Coverity CID 464589 Fixes: 6d118a0b9def ("Add lzma_filters_copy().") --- src/liblzma/common/filter_common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/liblzma/common/filter_common.c b/src/liblzma/common/filter_common.c index d15d9cc9..6c06c78d 100644 --- a/src/liblzma/common/filter_common.c +++ b/src/liblzma/common/filter_common.c @@ -213,8 +213,8 @@ lzma_filters_copy(const lzma_filter *src, lzma_filter *real_dest, error: // Free the options which we have already allocated. - while (i-- > 0) - lzma_free(dest[i].options, allocator); + while (i > 0) + lzma_free(dest[--i].options, allocator); return ret; }