root/xz
1
0
Fork 0
mirror of https://git.tukaani.org/xz.git synced 2025-05-04 05:16:38 +00:00
Code Issues Releases Wiki Activity

xz, xzdec: Capsicum sandbox: Fix incorrect use of cap_rights_clear()

Browse Source 
cap_rights_clear() with no additional arguments acts as a no-op, so
instead of removing all capability rights from STDIN_FILENO, the same
rights were allowed for STDIN_FILENO as were allowed for src_fd.

Fixes: a0eecc235d3b ("xz: Make Capsicum sandbox more strict with stdin and stdout.")
(The commit message says "stdout". It should have said "stderr".)
This commit is contained in:
Guillaume Outters 2025-04-25 02:55:08 +02:00 committed by Lasse Collin
parent 56aa9a0796
commit 5cc2e479eb
No known key found for this signature in database
GPG Key ID: 38EE757D69184620
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/xz/sandbox.c
View File

@ -274,7 +274,7 @@ sandbox_enable_strict_if_allowed(
// If not reading from stdin, remove all capabilities from it. // If not reading from stdin, remove all capabilities from it.
if (src_fd != STDIN_FILENO && cap_rights_limit( if (src_fd != STDIN_FILENO && cap_rights_limit(
STDIN_FILENO, cap_rights_clear(&rights))) STDIN_FILENO, cap_rights_init(&rights)))
goto error; goto error;
if (cap_rights_limit(STDOUT_FILENO, cap_rights_init(&rights, if (cap_rights_limit(STDOUT_FILENO, cap_rights_init(&rights,

2
src/xzdec/xzdec.c
View File

@ -321,7 +321,7 @@ sandbox_enter(int src_fd)
// If not reading from stdin, remove all capabilities from it. // If not reading from stdin, remove all capabilities from it.
if (src_fd != STDIN_FILENO && cap_rights_limit( if (src_fd != STDIN_FILENO && cap_rights_limit(
STDIN_FILENO, cap_rights_clear(&rights))) STDIN_FILENO, cap_rights_init(&rights)))
goto error; goto error;
if (cap_rights_limit(STDOUT_FILENO, cap_rights_init(&rights, if (cap_rights_limit(STDOUT_FILENO, cap_rights_init(&rights,