root
/
xz
mirror of https://git.tukaani.org/xz.git
1
0
Fork 0
Code Issues Releases Wiki Activity

Tests: test_filter_flags: Edit comments and style

This commit is contained in:
Lasse Collin 2024-04-22 18:35:19 +03:00
parent b101e1d1db
commit 2f06920f20
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
tests/test_filter_flags.c
View File

@ -101,6 +101,7 @@ test_lzma_filter_flags_size(void)
// block header. // block header.
uint32_t size = 0; uint32_t size = 0;
if (lzma_filter_encoder_is_supported(LZMA_FILTER_LZMA1)) { if (lzma_filter_encoder_is_supported(LZMA_FILTER_LZMA1)) {
// LZMA1 isn't supported in .xz so we get LZMA_PROG_ERROR.
assert_lzma_ret(lzma_filter_flags_size(&size, assert_lzma_ret(lzma_filter_flags_size(&size,
&lzma1_filter), LZMA_PROG_ERROR); &lzma1_filter), LZMA_PROG_ERROR);
} }
@ -156,7 +157,7 @@ verify_filter_flags_encode(lzma_filter *filter, bool should_encode)
// First calculate the size of Filter Flags to know how much // First calculate the size of Filter Flags to know how much
// memory to allocate to hold the encoded Filter Flags // memory to allocate to hold the encoded Filter Flags
assert_lzma_ret(lzma_filter_flags_size(&size, filter), LZMA_OK); assert_lzma_ret(lzma_filter_flags_size(&size, filter), LZMA_OK);
uint8_t *encoded_out = tuktest_malloc(size * sizeof(uint8_t)); uint8_t *encoded_out = tuktest_malloc(size);
size_t out_pos = 0; size_t out_pos = 0;
if (!should_encode) { if (!should_encode) {
assert_false(lzma_filter_flags_encode(filter, encoded_out, assert_false(lzma_filter_flags_encode(filter, encoded_out,
@ -266,7 +267,6 @@ test_lzma_filter_flags_encode(void)
size_t out_size = LZMA_BLOCK_HEADER_SIZE_MAX; size_t out_size = LZMA_BLOCK_HEADER_SIZE_MAX;
uint8_t out[LZMA_BLOCK_HEADER_SIZE_MAX]; uint8_t out[LZMA_BLOCK_HEADER_SIZE_MAX];
// Filter ID outside of valid range // Filter ID outside of valid range
assert_lzma_ret(lzma_filter_flags_encode(&bad_filter, out, &out_pos, assert_lzma_ret(lzma_filter_flags_encode(&bad_filter, out, &out_pos,
out_size), LZMA_PROG_ERROR); out_size), LZMA_PROG_ERROR);
@ -331,7 +331,8 @@ test_lzma_filter_flags_encode(void)
// because it is agnostic to the type of options used in the call // because it is agnostic to the type of options used in the call
#if defined(HAVE_ENCODERS) && defined(HAVE_DECODERS) #if defined(HAVE_ENCODERS) && defined(HAVE_DECODERS)
static void static void
verify_filter_flags_decode(lzma_filter *filter_in, lzma_filter *filter_out) verify_filter_flags_decode(const lzma_filter *filter_in,
lzma_filter *filter_out)
{ {
uint32_t total_size = 0; uint32_t total_size = 0;
@ -401,7 +402,11 @@ test_lzma_filter_flags_decode(void)
&bcj_decoded); &bcj_decoded);
assert_true(bcj_decoded.options == NULL); assert_true(bcj_decoded.options == NULL);
// Next test with offset // Next test with start_offset.
//
// NOTE: The encoder and decoder don't verify if
// the start_offset is valid for the filter. Only
// the encoder or decoder initialization does.
lzma_options_bcj options = { lzma_options_bcj options = {
.start_offset = 257 .start_offset = 257
}; };