From 1c0dfaee6376adb4b302b7d27c49de8fd5a5bd52 Mon Sep 17 00:00:00 2001 From: Lasse Collin Date: Tue, 23 Apr 2024 16:35:08 +0300 Subject: [PATCH] Tests: test_filter_str: Move one assertion and add a comment (cherry picked from commit 26c69be80523b05c84dea86c47c4ddd9a10945d7) --- tests/test_filter_str.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/test_filter_str.c b/tests/test_filter_str.c index f88404f2..d37666df 100644 --- a/tests/test_filter_str.c +++ b/tests/test_filter_str.c @@ -437,6 +437,10 @@ test_lzma_str_from_filters(void) assert_true(lzma_str_to_filters("x86 lzma2", NULL, filters, 0, NULL) == NULL); + // It always allocates the options structure even when it's not + // needed due to start_offset = 0 being the default. + assert_true(filters[0].options != NULL); + assert_lzma_ret(lzma_str_from_filters(&output_str, filters, 0, NULL), LZMA_OK); @@ -445,9 +449,7 @@ test_lzma_str_from_filters(void) free(output_str); // Test setting BCJ option to NULL. - assert_false(filters[0].options == NULL); free(filters[0].options); - filters[0].options = NULL; assert_lzma_ret(lzma_str_from_filters(&output_str, filters, 0, NULL),