root/xz
1
0
Fork 0
mirror of https://git.tukaani.org/xz.git synced 2025-03-23 08:50:43 +00:00
Code Issues Releases Wiki Activity

CMake: Fix tuklib_use_system_extensions

Browse Source 
Revert back to a macro so that list(APPEND CMAKE_REQUIRED_DEFINITIONS)
will affect the calling scope. I had forgotten that while CMake
functions inherit the variables from the parent scope, the changes
to them are local unless using set(... PARENT_SCOPE).

This also means that the commit message in 5bb77d0920dc is wrong. The
commit itself is still fine, making it clearer that -DHAVE_SYS_PARAM_H
is only needed for specific check_c_source_compiles() calls.

Fixes: c1ea7bd0b60eed6ebcdf9a713ca69034f6f07179
This commit is contained in:
Lasse Collin 2025-03-10 13:13:30 +02:00
parent 80e4883602
commit 1028e52c93
No known key found for this signature in database
GPG Key ID: 38EE757D69184620
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
cmake/tuklib_common.cmake
View File

@ -26,7 +26,10 @@ endfunction()
# This is an over-simplified version of AC_USE_SYSTEM_EXTENSIONS in Autoconf
# or gl_USE_SYSTEM_EXTENSIONS in gnulib.
function(tuklib_use_system_extensions)
#
# NOTE: This is a macro because the changes to CMAKE_REQUIRED_DEFINITIONS
# must be visible in the calling scope.
macro(tuklib_use_system_extensions)
if(NOT MSVC)
add_compile_definitions(
_GNU_SOURCE # glibc, musl, mingw-w64
@ -50,4 +53,4 @@ function(tuklib_use_system_extensions)
-D_ALL_SOURCE
)
endif()
endfunction()
endmacro()