root
/
walk.js
1
0
Fork 0
Code Issues 3 Pull Requests Projects Releases Wiki Activity

TypeScript type definitions #2

New Issue
Open
opened 2022-01-03 15:56:51 +00:00 by Ghost · 1 comment
Ghost commented 2022-01-03 15:56:51 +00:00
Copy Link

Similar to how @types/walk exists for fs-walk.js, there should be a package with TypeScript type definitions for @root/walk.js

Currently, trying to use @root/walk.js with TypeScript (without setting noImplicitAny to false in the compiler options) results in an error like below:

src/controller.ts:5:22 - error TS7016: Could not find a declaration file for module '@root/walk'. '/home/murchu27/repos/apemusic-server/node_modules/@root/walk/index.js' implicitly has an 'any' type.
  Try `npm i --save-dev @types/root__walk` if it exists or add a new declaration (.d.ts) file containing `declare module '@root/walk';`
Similar to how [@types/walk](https://www.npmjs.com/package/@types/walk) exists for [fs-walk.js](https://git.coolaj86.com/coolaj86/fs-walk.js), there should be a package with TypeScript type definitions for @root/walk.js Currently, trying to use @root/walk.js with TypeScript (without setting `noImplicitAny` to false in the compiler options) results in an error like below: ``` src/controller.ts:5:22 - error TS7016: Could not find a declaration file for module '@root/walk'. '/home/murchu27/repos/apemusic-server/node_modules/@root/walk/index.js' implicitly has an 'any' type. Try `npm i --save-dev @types/root__walk` if it exists or add a new declaration (.d.ts) file containing `declare module '@root/walk';` ```
coolaj86 commented 2022-01-03 17:49:47 +00:00
Owner
Copy Link

Hey @murchu27, I've copied this issue over to GitHub (https://github.com/therootcompany/walk.js/issues/1) and flagged it good first issue and up-for-grabs.

I think this could be a simple matter of adding jsdoc to the file.

Hey @murchu27, I've copied this issue over to GitHub (https://github.com/therootcompany/walk.js/issues/1) and flagged it good `first issue` and `up-for-grabs`. I think this could be a simple matter of adding jsdoc to the file.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
master
esmodule
v1.1.0
v1.0.0
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: root/walk.js#2
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?