root/request.js
2
0
Fork 0
mirror of https://github.com/therootcompany/request.js synced 2025-06-30 20:06:33 +00:00
Code Issues Releases Wiki Activity

query string support #3

New Issue
Closed
opened 2020-02-28 12:09:06 +00:00 by Ghost · 4 comments
Ghost commented 2020-02-28 12:09:06 +00:00
Copy Link

There's a useQuerystring: false in index.js, but not really any query string support.

I would say that handling query strings is a an expected feature as much as forms and well deserving a few lines.

There's a `useQuerystring: false` in index.js, but not really any query string support. I would say that handling query strings is a an expected feature as much as forms and well deserving a few lines.
coolaj86 commented 2020-02-28 18:40:38 +00:00
Owner
Copy Link

That option is leftover and had to do with querystring vs qs vs url.

Query strings should just be part of the URL path as per usual.

What did you try that didn’t work?

That option is leftover and had to do with `querystring` vs `qs` vs `url`. Query strings should just be part of the URL path as per usual. What did you try that didn’t work?
Ghost commented 2020-02-29 14:25:14 +00:00
Author
Copy Link

I don't have the code at hand but requests supports a qs object and it will do the proper encoding and concatenation. That's more readable IMHO.

FYI I ended up rewriting some code and use axios, this was just a nuisance, take this issue as a suggestion. The showstopper were timeouts, in my tests on Node timeout did not do anything.

I don't have the code at hand but requests supports a `qs` object and it will do the proper encoding and concatenation. That's more readable IMHO. FYI I ended up rewriting some code and use axios, this was just a nuisance, take this issue as a suggestion. The showstopper were timeouts, in my tests on Node `timeout` did not do anything.
coolaj86 commented 2020-03-12 08:40:09 +00:00
Owner
Copy Link

In what way does it accept a qs object? Can you show me an example?

In what way does it accept a qs object? Can you show me an example?
coolaj86 commented 2020-04-21 05:58:28 +00:00
Owner
Copy Link

Since I never got an example of what the code looks like, and I don't know what the issue is, I'm closing this out.

Since I never got an example of what the code looks like, and I don't know what the issue is, I'm closing this out.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
coolaj86
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: root/request.js#3
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?