dryrun testfiles in the challenge directory are not removed #3

New Issue

Ghost · 2019-07-31T12:28:42Z

Ghost commented

2019-07-31 12:28:42 +00:00

I'm using greenlock together with le-challenge-fs and greenlock-store-fs to create certificates via the http-01 challenge type

const challengepath = ...;
const settingspath = ...; 


greenlock = Greenlock.create({
  version: 'draft-12',
  server: useprodction 
    ? "https://acme-v02.api.letsencrypt.org/directory" 
    : "https://acme-staging-v02.api.letsencrypt.org/directory",
  challengeType: 'http-01',
  challenges: { "http-01": require('le-challenge-fs').create({ webrootPath: challengepath}) },
  store: require('greenlock-store-fs').create({ configDir: settingspath }),
  agreeToTerms: (opts, cb) => cb(null, opts.tosUrl)
});


...


greenlock.register(opts).then(...)

Generating certificates works fine, but after some testruns I have a lot of files named test-..... in my challenge directory. While the real challenge files are deleted, once the certificate is successfully created, these files remain (I suppose they stem from the dryrun, because first I had dryrunerrors and these names came up in the error message.)

I'm using greenlock together with `le-challenge-fs` and `greenlock-store-fs` to create certificates via the http-01 challenge type const challengepath = ...; const settingspath = ...; greenlock = Greenlock.create({ version: 'draft-12', server: useprodction ? "https://acme-v02.api.letsencrypt.org/directory" : "https://acme-staging-v02.api.letsencrypt.org/directory", challengeType: 'http-01', challenges: { "http-01": require('le-challenge-fs').create({ webrootPath: challengepath}) }, store: require('greenlock-store-fs').create({ configDir: settingspath }), agreeToTerms: (opts, cb) => cb(null, opts.tosUrl) }); ... greenlock.register(opts).then(...) Generating certificates works fine, but after some testruns I have a lot of files named `test-.....` in my challenge directory. While the real challenge files are deleted, once the certificate is successfully created, these files remain (I suppose they stem from the dryrun, because first I had dryrunerrors and these names came up in the error message.)

coolaj86 commented

2019-10-15 17:05:00 +00:00

This has been fixed in ACME.js v3 and will be present in Greenlock v3.

For updates see the campaign page:

https://www.indiegogo.com/projects/greenlock-v3-easy-https-for-node-js--2/x/18176437#/

This has been fixed in ACME.js v3 and will be present in Greenlock v3. For updates see the campaign page: * https://www.indiegogo.com/projects/greenlock-v3-easy-https-for-node-js--2/x/18176437#/

coolaj86 closed this issue

2019-11-01 21:50:13 +00:00

Sign in to join this conversation.

No Label

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: root/greenlock.js#3