root
/
greenlock.js
mirror of https://github.com/therootcompany/greenlock.js.git
2
0
Fork 0
Code Issues 27 Releases Wiki Activity

https://git.coolaj86.com/coolaj86/greenlock-express.js/issues/24 lightly sanitize sni

This commit is contained in:
AJ ONeal 2018-07-04 01:53:40 -06:00
parent 9e06859f62
commit f2d989ffed
1 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
index.js
View File

@ -389,7 +389,7 @@ Greenlock.create = function (gl) {
console.error(""); console.error("");
cb(e); cb(e);
} }
);; );
} }
else { else {
log(gl.debug, 'gl getting from disk or registering new'); log(gl.debug, 'gl getting from disk or registering new');
@ -416,6 +416,17 @@ Greenlock.create = function (gl) {
gl.sni = gl.sni.create(gl); gl.sni = gl.sni.create(gl);
} }
gl.tlsOptions.SNICallback = function (domain, cb) { gl.tlsOptions.SNICallback = function (domain, cb) {
// format and (lightly) sanitize sni so that users can be naive
// and not have to worry about SQL injection or fs discovery
domain = (domain||'').toLowerCase();
// hostname labels allow a-z, 0-9, -, and are separated by dots
// _ is sometimes allowed
if (!/^[a-z0-9_\.\-]+$/i.test(domain) || -1 !== domain.indexOf('..')) {
log(gl.debug, "invalid sni '" + domain + "'");
cb(new Error("invalid SNI"));
return;
}
try { try {
gl.sni.sniCallback(domain, cb); gl.sni.sniCallback(domain, cb);
} catch(e) { } catch(e) {