altnames in domain table? #7

New Issue

coolaj86 · 2019-05-09T07:35:22Z

coolaj86 commented

2019-05-09 07:35:22 +00:00

It looks like the domains table may be wrong.

It should be that if a request comes in for bar.example.com and the certificate subject is example.com and has altnames foobar.dev and *.example.com, then the list I should get back is example.com,foobar.dev,*.example.com.

Therefore I think that the Domain model should have a subject and an altname (or maybe name and group).

When the record is found I should get back the full list of all records that have the same subject as the currently queried domain.

It looks like the domains table may be wrong. It should be that if a request comes in for `bar.example.com` and the certificate subject is `example.com` and has altnames `foobar.dev` and `*.example.com`, then the list I should get back is `example.com,foobar.dev,*.example.com`. Therefore I think that the Domain model should have a `subject` and an `altname` (or maybe `name` and `group`). When the record is found I should get back the full list of all records that have the same subject as the currently queried domain.

coolaj86 commented

2019-05-09 07:38:06 +00:00

Oh, it looks like that was prep-work for the approveDomains and is unrelated to the store plugin's core functionality.

Oh, it looks like that was prep-work for the `approveDomains` and is unrelated to the store plugin's core functionality.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: root/greenlock-store-sequelize.js#7