root
/
greenlock-store-sequelize.js
2
0
Fork 0
Code Issues 1 Pull Requests Releases Activity

altnames in domain table? #7

New Issue
Open
opened 2019-05-09 07:35:22 +00:00 by coolaj86 · 1 comment
coolaj86 commented 2019-05-09 07:35:22 +00:00
Owner
Copy Link

It looks like the domains table may be wrong.

It should be that if a request comes in for bar.example.com and the certificate subject is example.com and has altnames foobar.dev and *.example.com, then the list I should get back is example.com,foobar.dev,*.example.com.

Therefore I think that the Domain model should have a subject and an altname (or maybe name and group).

When the record is found I should get back the full list of all records that have the same subject as the currently queried domain.

It looks like the domains table may be wrong. It should be that if a request comes in for `bar.example.com` and the certificate subject is `example.com` and has altnames `foobar.dev` and `*.example.com`, then the list I should get back is `example.com,foobar.dev,*.example.com`. Therefore I think that the Domain model should have a `subject` and an `altname` (or maybe `name` and `group`). When the record is found I should get back the full list of all records that have the same subject as the currently queried domain.
coolaj86 commented 2019-05-09 07:38:06 +00:00
Author
Owner
Copy Link

Oh, it looks like that was prep-work for the approveDomains and is unrelated to the store plugin's core functionality.

Oh, it looks like that was prep-work for the `approveDomains` and is unrelated to the store plugin's core functionality.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
missing-dir
v3.0.3
v3.0.2
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: root/greenlock-store-sequelize.js#7
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?