I'm trying to write a manager which is backed by Amazon DynamoDB, and use that manager with greenlock-express.
I've got the basics working, but from trying to read through the greenlock base code, it seems that it only ever calls .find({}) on the manager type. I.e. it never tries to filter by subject.
So I implemented a simple find function that will return everything.
However the manager tests are failing because it expects find({ subject: siteAltname }) and find({ servernames: [siteAltname], altnames: [siteAltname] })
to be implemented.
Are they truly required? Under what circumstances will they be used?
I'm trying to write a manager which is backed by Amazon DynamoDB, and use that manager with greenlock-express.
I've got the basics working, but from trying to read through the greenlock base code, it seems that it only ever calls `.find({})` on the manager type. I.e. it never tries to filter by subject.
So I implemented a simple `find` function that will return everything.
However the manager tests are failing because it expects `find({ subject: siteAltname })` and `find({ servernames: [siteAltname], altnames: [siteAltname] })`
to be implemented.
Are they truly required? Under what circumstances will they be used?
I.e. it implies that renewBefore was tested, but in fact renewBefore is never set in the test.
It's pretty confusing what actually needs to be implemented in this function.
I also noticed that the test outputs:
```js
console.info("PASS: find({ servernames, renewBefore })");
```
I.e. it implies that `renewBefore` was tested, but in fact `renewBefore` is never set in the test.
It's pretty confusing what actually needs to be implemented in this function.
I'm trying to write a manager which is backed by Amazon DynamoDB, and use that manager with greenlock-express.
I've got the basics working, but from trying to read through the greenlock base code, it seems that it only ever calls
.find({})on the manager type. I.e. it never tries to filter by subject.So I implemented a simple
findfunction that will return everything.However the manager tests are failing because it expects
find({ subject: siteAltname })andfind({ servernames: [siteAltname], altnames: [siteAltname] })to be implemented.
Are they truly required? Under what circumstances will they be used?
I also noticed that the test outputs:
I.e. it implies that
renewBeforewas tested, but in factrenewBeforeis never set in the test.It's pretty confusing what actually needs to be implemented in this function.