config.sites not initialized #5

New Issue

Ghost · 2019-10-30T09:17:12Z

Ghost commented

2019-10-30 09:17:12 +00:00

Hello,

as a backer I started using greenlock-express v3 with the recommandation from migration guide.

I tested with version 3.0.6 and a "find" implementation as I don't want to create manually a json file in home directory.

It is working well, except at first run when no config file exists, where I get this error because config.sites is not initialized

TypeError: Cannot set property 'tondoux.apinfor.fr' of undefined
    at /root/app/node_modules/greenlock-manager-fs/manager.js:251:34
    at Array.forEach (<anonymous>)
    at /root/app/node_modules/greenlock-manager-fs/manager.js:250:14

Thanks for your work

Sylvain

Hello, as a backer I started using greenlock-express v3 with the recommandation from migration guide. I tested with version 3.0.6 and a "find" implementation as I don't want to create manually a json file in home directory. It is working well, except at first run when no config file exists, where I get this error because config.sites is not initialized ``` TypeError: Cannot set property 'tondoux.apinfor.fr' of undefined at /root/app/node_modules/greenlock-manager-fs/manager.js:251:34 at Array.forEach (<anonymous>) at /root/app/node_modules/greenlock-manager-fs/manager.js:250:14 ``` Thanks for your work Sylvain

coolaj86 commented

2019-10-30 18:45:46 +00:00

Thanks for the report.

What I'll do, for the special case of the fs plugins, is have a linter that just runs on init to make sure that everything exists in a workable format.

I'll have this published tonight.

Thanks for the report. What I'll do, for the special case of the fs plugins, is have a linter that just runs on init to make sure that everything exists in a workable format. I'll have this published tonight.

coolaj86 commented

2019-10-31 12:56:06 +00:00

The manager plugin has been paired down, some linting added, and it now has a nice test suite:

I'm going to close this out because I believe it is fixed.

Please re-open if you have any issues.

The manager plugin has been paired down, some linting added, and it now has a nice test suite: * https://git.rootprojects.org/root/greenlock-manager-fs.js * https://git.rootprojects.org/root/greenlock-manager-test.js I'm going to close this out because I believe it is fixed. Please re-open if you have any issues.

coolaj86 closed this issue

2019-10-31 12:56:07 +00:00

Sign in to join this conversation.

No Label

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: root/greenlock-express.js#5