golib/net/httpcache/httpcache.go
AJ ONeal ba64018838
fix(httpcache): propagate sidecar write errors from Fetch
saveMeta now returns an error instead of silently swallowing WriteFile/
Rename failures. Fetch wraps and returns it (with updated=true, since
the body rename already succeeded). Callers get a loud signal when the
sidecar can't be written — the body is still good, but the next
conditional GET may redownload.
2026-04-20 17:00:22 -06:00

232 lines
6.2 KiB
Go

package httpcache
import (
"encoding/base64"
"encoding/json"
"fmt"
"io"
"net"
"net/http"
"os"
"path/filepath"
"sync"
"time"
)
// BasicAuth returns an HTTP Basic Authorization header value:
// "Basic " + base64(user:pass). Pair with the "Authorization" header in
// Cacher.Header.
func BasicAuth(user, pass string) string {
return "Basic " + base64.StdEncoding.EncodeToString([]byte(user+":"+pass))
}
// Bearer returns a Bearer Authorization header value: "Bearer " + token.
// Pair with the "Authorization" header in Cacher.Header.
func Bearer(token string) string {
return "Bearer " + token
}
const (
defaultConnTimeout = 5 * time.Second // TCP connect + TLS handshake
defaultTimeout = 5 * time.Minute // overall including body read
)
// Cacher fetches a URL to a local file, using ETag/Last-Modified to skip
// unchanged responses.
//
// Rate limiting — two independent gates, both checked before any HTTP:
// - MaxAge: skips if the local file's mtime is within this duration.
// Useful when the remote preserves meaningful timestamps (e.g. MaxMind
// encodes the database release date as the tar entry mtime).
// - MinInterval: skips if Fetch was called within this duration (in-memory).
// Guards against tight poll loops hammering a rate-limited API.
//
// Caching — ETag and Last-Modified values are persisted to a <path>.meta
// sidecar file so conditional GETs survive process restarts.
//
// Header — any values in Header are sent on every request. Authorization
// headers are stripped before following redirects so presigned targets
// (e.g. S3/R2 URLs) never receive credentials. The BasicAuth and Bearer
// helpers produce Authorization values for the common cases.
type Cacher struct {
URL string
Path string
ConnTimeout time.Duration // 0 uses 5s; caps TCP connect + TLS handshake
Timeout time.Duration // 0 uses 5m; caps overall request including body read
MaxAge time.Duration // 0 disables; skip HTTP if file mtime is within this
MinInterval time.Duration // 0 disables; skip HTTP if last Fetch attempt was within this
Header http.Header // headers sent on every request (Authorization is stripped on redirect)
mu sync.Mutex
etag string
lastMod string
lastChecked time.Time
metaLoaded bool
}
// cacheMeta is the sidecar format persisted alongside the downloaded file.
type cacheMeta struct {
ETag string `json:"etag,omitempty"`
LastMod string `json:"last_modified,omitempty"`
}
func (c *Cacher) metaPath() string { return c.Path + ".meta" }
// loadMeta reads etag/lastMod from the sidecar file. Errors are silently
// ignored — a missing or corrupt sidecar just means a full download next time.
func (c *Cacher) loadMeta() {
data, err := os.ReadFile(c.metaPath())
if err != nil {
return
}
var m cacheMeta
if err := json.Unmarshal(data, &m); err != nil {
return
}
c.etag = m.ETag
c.lastMod = m.LastMod
}
// saveMeta writes etag/lastMod to the sidecar file atomically.
func (c *Cacher) saveMeta() error {
m := cacheMeta{ETag: c.etag, LastMod: c.lastMod}
data, err := json.Marshal(m)
if err != nil {
return err
}
tmp := c.metaPath() + ".tmp"
if err := os.WriteFile(tmp, data, 0o644); err != nil {
return err
}
if err := os.Rename(tmp, c.metaPath()); err != nil {
_ = os.Remove(tmp)
return err
}
return nil
}
// New creates a Cacher that fetches URL and writes it to path.
func New(url, path string) *Cacher {
return &Cacher{URL: url, Path: path}
}
// Fetch sends a conditional GET and writes new content to Path if the server
// responds with 200. Returns whether the file was updated.
//
// Both MaxAge and MinInterval are checked before making any HTTP request.
func (c *Cacher) Fetch() (updated bool, err error) {
// MaxAge: file-mtime gate (no lock needed — just a stat).
if c.MaxAge > 0 {
if info, err := os.Stat(c.Path); err == nil {
if time.Since(info.ModTime()) < c.MaxAge {
return false, nil
}
}
}
c.mu.Lock()
defer c.mu.Unlock()
// Load sidecar once so conditional GETs work after a process restart.
if !c.metaLoaded {
c.loadMeta()
c.metaLoaded = true
}
// MinInterval: in-memory last-checked gate.
if c.MinInterval > 0 && !c.lastChecked.IsZero() {
if time.Since(c.lastChecked) < c.MinInterval {
return false, nil
}
}
c.lastChecked = time.Now()
connTimeout := c.ConnTimeout
if connTimeout == 0 {
connTimeout = defaultConnTimeout
}
timeout := c.Timeout
if timeout == 0 {
timeout = defaultTimeout
}
req, err := http.NewRequest(http.MethodGet, c.URL, nil)
if err != nil {
return false, err
}
if c.etag != "" {
req.Header.Set("If-None-Match", c.etag)
} else if c.lastMod != "" {
req.Header.Set("If-Modified-Since", c.lastMod)
}
transport := &http.Transport{
DialContext: (&net.Dialer{Timeout: connTimeout}).DialContext,
TLSHandshakeTimeout: connTimeout,
}
for k, vs := range c.Header {
for _, v := range vs {
req.Header.Add(k, v)
}
}
client := &http.Client{Timeout: timeout, Transport: transport}
// Strip Authorization before following any redirect — redirect targets
// (e.g. presigned S3/R2 URLs) must not receive our credentials.
client.CheckRedirect = func(req *http.Request, via []*http.Request) error {
req.Header.Del("Authorization")
return nil
}
resp, err := client.Do(req)
if err != nil {
return false, err
}
defer resp.Body.Close()
if resp.StatusCode == http.StatusNotModified {
return false, nil
}
if resp.StatusCode != http.StatusOK {
return false, fmt.Errorf("unexpected status %d fetching %s", resp.StatusCode, c.URL)
}
if err := os.MkdirAll(filepath.Dir(c.Path), 0o755); err != nil {
return false, err
}
tmp := c.Path + ".tmp"
f, err := os.Create(tmp)
if err != nil {
return false, err
}
n, err := io.Copy(f, resp.Body)
f.Close()
if err != nil {
os.Remove(tmp)
return false, err
}
if n == 0 {
os.Remove(tmp)
return false, fmt.Errorf("empty response from %s", c.URL)
}
if err := os.Rename(tmp, c.Path); err != nil {
os.Remove(tmp)
return false, err
}
if etag := resp.Header.Get("ETag"); etag != "" {
c.etag = etag
}
if lm := resp.Header.Get("Last-Modified"); lm != "" {
c.lastMod = lm
}
if err := c.saveMeta(); err != nil {
return true, fmt.Errorf("save meta for %s: %w", c.Path, err)
}
return true, nil
}