root/golib
1
0
Fork 0
mirror of https://github.com/therootcompany/golib.git synced 2026-04-24 12:48:00 +00:00
Code Issues Projects Releases Wiki Activity

test(dataset): update loader signatures to func(ctx) (*T, error)

Browse Source 
Follow-up to the loader ctx plumbing — existing unit tests didn't
compile against the new signature.
This commit is contained in:
AJ ONeal 2026-04-20 20:09:36 -06:00
parent 0d9df94a24
commit ee67cf05bc
No known key found for this signature in database
1 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
sync/dataset/dataset_test.go
View File

@ -1,6 +1,7 @@
package dataset_test package dataset_test
import ( import (
"context"
"errors" "errors"
"os" "os"
"sync/atomic" "sync/atomic"
@ -26,12 +27,12 @@ func TestSet_LoadPopulatesAllViews(t *testing.T) {
g := dataset.NewSet(f) g := dataset.NewSet(f)
var aCalls, bCalls int var aCalls, bCalls int
a := dataset.Add(g, func() (*string, error) { a := dataset.Add(g, func(_ context.Context) (*string, error) {
aCalls++ aCalls++
v := "a" v := "a"
return &v, nil return &v, nil
}) })
b := dataset.Add(g, func() (*int, error) { b := dataset.Add(g, func(_ context.Context) (*int, error) {
bCalls++ bCalls++
v := 42 v := 42
return &v, nil return &v, nil
@ -58,7 +59,7 @@ func TestSet_SecondLoadSkipsUnchanged(t *testing.T) {
f := &countFetcher{updated: false} f := &countFetcher{updated: false}
g := dataset.NewSet(f) g := dataset.NewSet(f)
calls := 0 calls := 0
dataset.Add(g, func() (*string, error) { dataset.Add(g, func(_ context.Context) (*string, error) {
calls++ calls++
v := "x" v := "x"
return &v, nil return &v, nil
@ -81,7 +82,7 @@ func TestSet_LoadOnUpdateSwaps(t *testing.T) {
f := &countFetcher{updated: true} f := &countFetcher{updated: true}
g := dataset.NewSet(f) g := dataset.NewSet(f)
n := 0 n := 0
v := dataset.Add(g, func() (*int, error) { v := dataset.Add(g, func(_ context.Context) (*int, error) {
n++ n++
return &n, nil return &n, nil
}) })
@ -98,7 +99,7 @@ func TestSet_LoadOnUpdateSwaps(t *testing.T) {
func TestSet_ValueBeforeLoad(t *testing.T) { func TestSet_ValueBeforeLoad(t *testing.T) {
g := dataset.NewSet(dataset.NopFetcher{}) g := dataset.NewSet(dataset.NopFetcher{})
v := dataset.Add(g, func() (*string, error) { v := dataset.Add(g, func(_ context.Context) (*string, error) {
s := "x" s := "x"
return &s, nil return &s, nil
}) })
@ -110,7 +111,7 @@ func TestSet_ValueBeforeLoad(t *testing.T) {
func TestSet_FetchError(t *testing.T) { func TestSet_FetchError(t *testing.T) {
f := &countFetcher{err: errors.New("offline")} f := &countFetcher{err: errors.New("offline")}
g := dataset.NewSet(f) g := dataset.NewSet(f)
dataset.Add(g, func() (*string, error) { dataset.Add(g, func(_ context.Context) (*string, error) {
s := "x" s := "x"
return &s, nil return &s, nil
}) })
@ -121,7 +122,7 @@ func TestSet_FetchError(t *testing.T) {
func TestSet_LoaderError(t *testing.T) { func TestSet_LoaderError(t *testing.T) {
g := dataset.NewSet(dataset.NopFetcher{}) g := dataset.NewSet(dataset.NopFetcher{})
dataset.Add(g, func() (*string, error) { dataset.Add(g, func(_ context.Context) (*string, error) {
return nil, errors.New("parse fail") return nil, errors.New("parse fail")
}) })
if err := g.Load(t.Context()); err == nil { if err := g.Load(t.Context()); err == nil {