root/golib
1
0
Fork 0
mirror of https://github.com/therootcompany/golib.git synced 2026-03-02 23:57:59 +00:00
Code Issues Projects Releases Wiki Activity

feat(monorel): push commits and tags before creating GitHub release

Browse Source 
Add Step 3 "git push && git push --tags" to the generated release script,
between the tag creation step and the goreleaser build step.  This fixes
HTTP 422 "Release.target_commitish is invalid" errors from the GitHub API,
which occur when the local commit (auto-created for a new .goreleaser.yaml)
has not yet been pushed to the remote.
This commit is contained in:
AJ ONeal 2026-02-28 23:45:00 -07:00
parent 25781032f9
commit e4402f4a4a
No known key found for this signature in database
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
tools/monorel/main.go
View File

@ -1322,7 +1322,10 @@ func printModuleScript(
line("# To undo: git tag -d %q", currentTag) line("# To undo: git tag -d %q", currentTag)
} }
section("Step 3: Build with goreleaser") section("Step 3: Push commits and tags to remote")
line("git push && git push --tags")
section("Step 4: Build with goreleaser")
line("# release.disable=true in .goreleaser.yaml; goreleaser only builds.") line("# release.disable=true in .goreleaser.yaml; goreleaser only builds.")
if relPath == "." { if relPath == "." {
line("goreleaser release --clean --skip=validate,announce") line("goreleaser release --clean --skip=validate,announce")
@ -1333,10 +1336,10 @@ func printModuleScript(
line(")") line(")")
} }
section("Step 4: Release notes") section("Step 5: Release notes")
line("%s=%s", notesVar, shellSingleQuote(releaseNotes)) line("%s=%s", notesVar, shellSingleQuote(releaseNotes))
section("Step 5: Create draft GitHub release") section("Step 6: Create draft GitHub release")
tagVersion := currentTag[strings.LastIndex(currentTag, "/")+1:] tagVersion := currentTag[strings.LastIndex(currentTag, "/")+1:]
title := projectName + " " + tagVersion title := projectName + " " + tagVersion
line("gh release create %q \\", currentTag) line("gh release create %q \\", currentTag)
@ -1348,7 +1351,7 @@ func printModuleScript(
line(" --draft \\") line(" --draft \\")
line(" --target %q", headSHA) line(" --target %q", headSHA)
section("Step 6: Upload artifacts") section("Step 7: Upload artifacts")
line("gh release upload %q \\", currentTag) line("gh release upload %q \\", currentTag)
for _, bin := range bins { for _, bin := range bins {
line(" %s/%s_*.tar.gz \\", distDir, bin.name) line(" %s/%s_*.tar.gz \\", distDir, bin.name)
@ -1357,7 +1360,7 @@ func printModuleScript(
line(" \"%s/%s_%s_checksums.txt\" \\", distDir, projectName, version) line(" \"%s/%s_%s_checksums.txt\" \\", distDir, projectName, version)
line(" --clobber") line(" --clobber")
section("Step 7: Publish release (remove draft)") section("Step 8: Publish release (remove draft)")
line("gh release edit %q --draft=false", currentTag) line("gh release edit %q --draft=false", currentTag)
blank() blank()