From 657b899f1a5766e8884fbcc88a3a8894962c0fb4 Mon Sep 17 00:00:00 2001 From: AJ ONeal Date: Mon, 6 Apr 2026 00:37:19 -0600 Subject: [PATCH] fix(shmigrate): restore missing-file comment, remove || true from sync MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Add # ERROR: MISSING FILE comment in generated script when a migration file doesn't exist (feature-branch friendly: script still includes the command, user decides what to do) - Remove || true from sync lines — if the log sync query fails, something is seriously wrong and the script should fail --- database/sqlmigrate/shmigrate/shmigrate.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/database/sqlmigrate/shmigrate/shmigrate.go b/database/sqlmigrate/shmigrate/shmigrate.go index 500a761..aea8f28 100644 --- a/database/sqlmigrate/shmigrate/shmigrate.go +++ b/database/sqlmigrate/shmigrate/shmigrate.go @@ -77,8 +77,11 @@ func (r *Migrator) exec(name, suffix, label string) error { logPath := unclean(r.LogPath) fmt.Fprintf(r.Writer, "# %s %s\n", label, name) + if _, err := os.Stat(filepath.Join(r.MigrationsDir, name+suffix)); err != nil { + fmt.Fprintln(r.Writer, "# ERROR: MISSING FILE") + } fmt.Fprintln(r.Writer, cmd) - fmt.Fprintf(r.Writer, "%s > %s || true\n", syncCmd, logPath) + fmt.Fprintf(r.Writer, "%s > %s\n", syncCmd, logPath) fmt.Fprintln(r.Writer) return nil