bugfixes and metadata updates

README.md

@@ -100,7 +100,7 @@ node ./test.js example.com johndoe xxxxxx
 # Authors
 
 -   AJ ONeal
--	Hitesh Walia
+-   Hitesh Walia
 
 See AUTHORS for contact info.
 
@@ -108,5 +108,6 @@ See AUTHORS for contact info.
 
 [acme-dns-01-dnsimple.js](https://git.coolaj86.com/coolaj86/acme-dns-01-dnsimple.js) | MPL-2.0 | [Terms of Use](https://therootcompany.com/legal/#terms) | [Privacy Policy](https://therootcompany.com/legal/#privacy)
 
+Copyright 2019 Hitesh Walia
 Copyright 2019 AJ ONeal
 Copyright 2019 The Root Group LLC

lib/index.js

@@ -46,6 +46,7 @@ module.exports.create = function(config) {
 		},
 		zones: function(data) {
 			// console.info('List Zones', data);
+
 			return api('GET', '/' + account + '/zones').then(function(resp) {
 				return resp['body']['data'].map(function(elem) {
 					//console.log('DEBUG >>> elem.name: ' + elem.name);
@@ -54,19 +55,19 @@ module.exports.create = function(config) {
 			});
 		},
 		set: function(data) {
+			// console.info('Add TXT', data);
 			var ch = data.challenge;
+
 			if (!ch.dnsZone) {
 				throw new Error('No matching zone for ' + ch.dnsHost);
 			}
-			// console.info('Add TXT', data);
-			var ch = data.challenge;
 			var txt = ch.dnsAuthorization;
 
 			return api(
 				'POST',
 				'/' + account + '/zones/' + ch.dnsZone + '/records',
 				{
-					name: '',
+					name: ch.dnsPrefix,
 					type: 'TXT',
 					content: txt
 				}
@@ -81,44 +82,58 @@ module.exports.create = function(config) {
 		},
 		get: function(data) {
 			// console.info('List TXT', data);
+			var ch = data.challenge;
 
+			// TODO use :name_like
+			// https://developer.dnsimple.com/v2/zones/records/
 			return api(
 				'GET',
 				'/' + account + '/zones/' + data.challenge.dnsZone + '/records'
 			).then(function(resp) {
 				var record = resp.body.data.filter(function(record) {
-					return data.challenge.dnsAuthorization === record.content;
+					return (
-				})[0];
+						ch.dnsPrefix === record.name &&
-
+						ch.dnsAuthorization === record.content
-				if (record) return { dnsAuthorization: record.content };
+					);
-				else return null;
-			});
-		},
-		remove: function(data) {
-			return api(
-				'GET',
-				'/' + account + '/zones/' + data.challenge.dnsZone + '/records'
-			).then(function(resp) {
-				var record = resp.body.data.filter(function(record) {
-					return data.challenge.dnsAuthorization === record.content;
 				})[0];
 
 				if (record) {
-					return api(
+					return { dnsAuthorization: record.content };
-						'DELETE',
+				}
-						'/' +
+
-							account +
+				return null;
-							'/zones/' +
+			});
-							data.challenge.dnsZone +
+		},
-							'/records/' +
+		remove: function(data) {
-							record.id
+			// console.info('Remove TXT', data);
-					).then(function(resp) {
+			var ch = data.challenge;
-						// console.info('DEBUG >>> resp: ', JSON.stringify(resp, null, 2));
+
-						return true;
+			return api(
-					});
+				'GET',
-				} else {
+				'/' + account + '/zones/' + data.challenge.dnsZone + '/records'
+			).then(function(resp) {
+				var record = resp.body.data.filter(function(record) {
+					return (
+						ch.dnsPrefix === record.name &&
+						ch.dnsAuthorization === record.content
+					);
+				})[0];
+
+				if (!record) {
 					throw new Error('Txt Record not found for removal');
 				}
+				return api(
+					'DELETE',
+					'/' +
+						account +
+						'/zones/' +
+						ch.dnsZone +
+						'/records/' +
+						record.id
+				).then(function(resp) {
+					// console.info('DEBUG >>> resp: ', JSON.stringify(resp, null, 2));
+					return true;
+				});
 			});
 		}
 	};

package.json

@@ -1,6 +1,6 @@
 {
 	"name": "acme-dns-01-dnsimple",
-	"version": "0.0.1",
+	"version": "3.0.0",
 	"description": "DNSimple + Let's Encrypt for Node.js - ACME dns-01 challenges w/ ACME.js and Greenlock.js",
 	"main": "index.js",
 	"files": [
@@ -12,7 +12,7 @@
 	},
 	"repository": {
 		"type": "git",
-		"url": "https://git.coolaj86.com/coolaj86/acme-dns-01-dnsimple.js.git"
+		"url": "https://git.rootprojects.org/root/acme-dns-01-dnsimple.js.git"
 	},
 	"keywords": [
 		"dnsimple",
@@ -22,7 +22,10 @@
 		"acme",
 		"greenlock"
 	],
-	"author": "AJ ONeal <coolaj86@gmail.com> (https://coolaj86.com/), Hitesh Walia <hiteshwar.walia@gmail.com",
+	"author": "Hitesh Walia <hiteshwar.walia@gmail.com",
+	"contributors": [
+		"AJ ONeal <coolaj86@gmail.com> (https://coolaj86.com/)"
+	],
 	"license": "MPL-2.0",
 	"devDependencies": {
 		"acme-challenge-test": "^3.3.2",